[Typescript][SDK] return null if escrow is not found in getEscrow#3623
Closed
flopez7 wants to merge 2 commits intocontracts-v2from
Closed
[Typescript][SDK] return null if escrow is not found in getEscrow#3623flopez7 wants to merge 2 commits intocontracts-v2from
flopez7 wants to merge 2 commits intocontracts-v2from
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
Contributor
Author
|
Since it's already done in #3616, we can close this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue tracking
N/A
Context behind the change
Fix
EscrowUtils.getEscrowto return null if escrow is not foundHow has this been tested?
Ran unit tests. Deployed dashboard locally to make some requests and check if it works.
Release plan
Deploy new SDK beta version
Potential risks; What to monitor; Rollback plan
None